feat(observability): add structured logging#51
Merged
Conversation
pkosiec
reviewed
Jan 15, 2026
Member
pkosiec
left a comment
There was a problem hiding this comment.
Nice job overall! A few comments from my side
| resource: this.createResource(config), | ||
| autoDetectResources: false, | ||
| sampler: new AlwaysOnSampler(), | ||
| sampler: new AppKitSampler(), |
Member
There was a problem hiding this comment.
Could you please test a deployed app with OpenTelemetry enabled in Apps runtime? I think it would be great to double-check everything works flawlessly there 👍
From my observations sampling result might differ between local dev and runtime, that's why the AlwaysOnSampler was set before (same as previous default OpenTelemetry config).
MarioCadenas
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WideEventclass for collecting rich request metadata (method, path, user, component, execution, stream, error context)AsyncLocalStoragefor automatic context propagation across interceptors and nested callsDetails
Standardized Errors
New error hierarchy with
AppKitErrorbase class providing:code,statusCode,isRetryable)ValidationError,AuthenticationError,ConfigurationError,ConnectionError,ExecutionError,InitializationError,ServerError,TunnelErrortoJSON()serializationValidationError.missingField("warehouseId"))Structured Logging
createLogger(scope)returns a logger with:logger.info(req, "Processing %s", id)tracks logs in WideEventlogger.event(req?)returns the current WideEvent (from AsyncLocalStorage or explicit req)Wide-Event Tracking (Honeycomb-style)
Request-scoped
WideEventcollects:Sampling
Configurable via
APPKIT_SAMPLE_RATEenv var with smart defaults: